Add NVIDIA SkillSpector as a complementary skill security scan - #38
Merged
Conversation
Layer NVIDIA SkillSpector on top of the existing audit:skills gate as an independent, advisory second opinion for marketplace packages. - scripts/scan-skillspector.mjs: renders each YAML package to a throwaway SKILL.md, runs SkillSpector static analysis, aggregates risk scores/issues, emits merged SARIF, and skips gracefully when the tool is not installed. - .github/workflows/skillspector.yml: advisory CI scan of changed packages that uploads SARIF to the Security tab (non-blocking). - package.json: add scan:skillspector script. - Document the layered scanning model in CONTRIBUTING.md and SECURITY.md.
criptogus
marked this pull request as ready for review
May 30, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Layers NVIDIA SkillSpector on top of the existing
audit:skillsgate as an independent, advisory second opinion for every marketplace package.audit:skillsstays the curated, high-precision blocking gate. SkillSpector adds NVIDIA's broader catalogue of vulnerability patterns (prompt injection, data exfiltration, privilege escalation, supply-chain, excessive agency, MCP tool poisoning, …) plus AST/YARA behavioural detection — without changing existing behavior.How
Marketplace packages are structured YAML, but SkillSpector expects a skill directory (a
SKILL.md). The wrapper renders each package's LLM-readable fields into a throwawaySKILL.md, runs SkillSpector's static analysis, and aggregates the results.scripts/scan-skillspector.mjs— renders → scans → aggregates risk scores/issues, emits merged SARIF, and skips gracefully (exit 0) when SkillSpector isn't installed, so local installs and unrelated CI stay green.--blockmakes it fail on any package at/above the risk threshold (default 50,SKILLSPECTOR_THRESHOLDto override)..github/workflows/skillspector.yml— advisory CI scan of changed packages on PRs touchingcontent/. Installs SkillSpector (pinned ref, Python 3.12 viauv), runs static-only (no LLM key needed), and uploads SARIF to the repo's Security tab.continue-on-error→ does not block merges.package.json—npm run scan:skillspector.CONTRIBUTING.md/SECURITY.md— document the layered scanning model.Validation
Tested locally end-to-end against real packages (skills/playbooks/souls/integrations):
curl | bash+ injection) → score 100,DO_NOT_INSTALL, 6 findings,--blockexits 1.--require.eslint+prettierclean.Notes / decisions for review
continue-on-errorin the workflow and pass--block.SKILLSPECTOR_LLM=1+ a provider key to enable semantic analysis locally.https://claude.ai/code/session_017yCVEShyDmhzgJXNVpMBoG
Generated by Claude Code