Skip to content

feat(shell): remove Genspark web projects view - #51

Merged
criptogus merged 1 commit into
mainfrom
feat/remove-genspark-projects
Aug 11, 2026
Merged

feat(shell): remove Genspark web projects view#51
criptogus merged 1 commit into
mainfrom
feat/remove-genspark-projects

Conversation

@criptogus

Copy link
Copy Markdown
Owner

Remove a feature morta Genspark Projects (view de projetos criados no site genspark.ai, herdada do upstream).

Motivo

O fork nao tem fluxo de conta Genspark (auth = gateway Hermes local :8642), entao a view nunca listava projetos — era UI morta com a marca do upstream exposta no sidebar de um app rebrandado.

Escopo

  • CloudProjectsView + entrada do sidebar + state cloudMode (Home.tsx, -339 linhas)
  • Canais IPC cloudProjects*/openCloudProject + tipos + bridge do preload
  • Modulo main/cloud-projects.ts + teste unitario deletados
  • 12 chaves i18n x 19 linguas removidas
  • Bloco CSS da view removido (521 linhas); Cloud sync entry (Google Drive) intacto

Validacao

  • Typecheck global: 0 erros
  • Testes: suite completa verde (149 shell)
  • Lint: 0 errors | Prettier: limpo
  • grep final: zero referencias no source

The 'Genspark Projects' sidebar entry listed projects created on the
genspark.ai website and opened them in the browser. The fork has no
Genspark account flow (auth is the local Hermes gateway), so the view
was dead UI that exposed the upstream brand. Removed end to end:
- CloudProjectsView component + sidebar entry + cloudMode state (Home.tsx)
- cloudProjects*/openCloudProject IPC channels, types and preload bridge
- cloud-projects.ts main module and its unit test
- 12 i18n keys across all 19 locales
- cloud view CSS block (521 lines); Drive cloud sync entry untouched

Typecheck global clean, 4k+ tests pass, lint 0 errors.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ee9f2e9f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 2112 to 2114
ipcMain.handle(HOME_CHANNELS.accountLogout, async () => {
// Fork: não há conta remota para encerrar sessão; só limpa o cache local
clearCloudProjectsStore(cloudProjectsStorePath())
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep clearing the legacy cloud-project cache

For users upgrading from a version that populated userData/cloud-projects.json, logout now leaves that file behind because this call was its only unconditional cleanup path and the module that could otherwise reject/delete it has also been removed. The cache contains project titles and URLs, so account metadata can remain on disk indefinitely after logout or feature removal; retain a small legacy-file cleanup here or perform it during startup migration.

Useful? React with 👍 / 👎.

@criptogus
criptogus merged commit 8a43553 into main Aug 11, 2026
3 checks passed
@criptogus
criptogus deleted the feat/remove-genspark-projects branch August 11, 2026 16:11
birhantprkc pushed a commit to birhantprkc/HermesOffice that referenced this pull request Aug 15, 2026
…us#51)

The two XMLParser instances in file-parse ran with fast-xml-parser's
defaults, so element text was numerically coerced and trimmed before it
reached the model: <t>02139</t> read as 2139, and the space carried by an
xml:space="preserve" run was dropped, so a bolded word in a slide turned
"Quarterly revenue grew 12% in Q3" into "Quarterlyrevenuegrew12%inQ3".

Set trimValues and parseTagValue to false on both, matching docx-engine's
xml-utils and pptx-engine's parse. trimValues is per parser rather than
per element, so two readers that were relying on it change with it: the
xlsx parser keeps collapsing attribute whitespace, since r:id, Target and
the cell ref are structural and a padded Target otherwise drops a whole
sheet, and collectText now pushes a primitive only when it came from an
a:t, so an <a:br> written across lines no longer leaks into the paragraph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant