This repository was archived by the owner on Jan 17, 2018. It is now read-only.
Fix time tracking in calendar helper, refs #19#125
Merged
jnv merged 1 commit intocrewmate:masterfrom Jun 7, 2014
kyzh:fix_time_tracking
Merged
Fix time tracking in calendar helper, refs #19#125jnv merged 1 commit intocrewmate:masterfrom kyzh:fix_time_tracking
jnv merged 1 commit intocrewmate:masterfrom
kyzh:fix_time_tracking
Conversation
Original Fix from Ben Zhang https://github.com/bzbnhang. Original pull request redbooth#40 Original comment: For instance, I have seted my time zone to Adelaide(9:30), if I go to the calendar at 9:00AM morning the current day is 8th Feb but in the Time tracking section, it shows today is 7th Feb. This because 9AM in Adelaide is around 5PM in San Francisco, which happens to be one day different.
|
The build have probably failed in one case due to some unrelated timing issues, so I will go ahead and merge this. Thanks! |
jnv
added a commit
that referenced
this pull request
Jun 7, 2014
Fix time tracking in calendar helper, refs #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Fix from Ben Zhang https://github.com/bzbnhang.
Original pull request redbooth#40
Original comment:
For instance, I have seted my time zone to Adelaide(9:30),
if I go to the calendar at 9:00AM morning the current day
is 8th Feb but in the Time tracking section, it shows today
is 7th Feb. This because 9AM in Adelaide is around 5PM in
San Francisco, which happens to be one day different.