Repository navigation
fix(cache): wait for packed manifest discovery - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A real IronMesh cache seed currently contains 172 PAC manifests. The first read-only restore correctly discovers them before listening, but v0.3.0's Action wrapper stopped waiting after 15 seconds. This change lets the wrapper wait for the same bounded timeout that the server already uses for discovery, preventing false startup failures and early cache misses.
Validation
node --test action/*.test.jsgo test ./...go vet ./...staticcheck,govulncheck, andactionlint