Repository navigation
fix(cache): restore large CARv2 blocks - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-blob-size-mb, plus the fixed CID framing overheadWhy
The first warm restore of IronMesh passed but consistently reported 11 fail-open misses while validating Action Results. The affected CAS blocks are larger than go-car's defensive 8 MiB default. IronMesh explicitly permits larger blobs (512 MiB by default), and CARv2 packs can contain a single large object, so the reader must use that configured limit.
Compatibility
This only changes the reader limit. Existing PACs remain immutable and become readable without reseeding.
Validation
node --test action/*.test.jsgo test ./...go vet ./...,staticcheck,govulncheck, andactionlint