Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RawKvClient::create([''])(and any other entry point that builds a connection throughConnectionFactory) threw the global\InvalidArgumentExceptionfor an empty PD endpoint, instead of the client exception type the documentation promises (Tikv\Client\Exception\InvalidArgumentException).ConnectionFactorynow validates every endpoint up front: each endpoint must be a non-empty string, otherwise the clientInvalidArgumentExceptionis thrown with the index of the offending endpoint.Changes
src/Client/Connection/ConnectionFactory.php: validate endpoints before creating the connection.tests/Unit/Connection/ConnectionFactoryTest.php: three new tests covering an empty-string endpoint, a non-string endpoint, and a valid endpoint list.CHANGELOG.md: entry under Unreleased > Fixed.Full unit suite passes locally: 132 tests, 282 assertions.
Closes #814