Repository navigation
Conversation
The last range ended at ';' (0x3B). With three or more workers that made the last range reversed, so RawKvScanner::batchScan() rejected the whole call with InvalidArgumentException through RegionRangeClipper::assertForwardRangeOrder() (before that validation the clipper would have skipped the range); with one or two workers the last range was valid but stopped at ';', silently covering only the 0-9 buckets. The float step strlen($chars) / $workers also made $chars[$i * $step] warn and truncate the offset for worker counts that do not divide 16. Boundaries now come from intdiv(), workers is clamped to 1..16, and the last range ends at $prefix . 'g'. ParallelScanDocumentationGuardTest evaluates the documented function for every worker count from 1 to 16 under a warning-to-exception handler and asserts the ranges are non-empty, contiguous and cover each bucket exactly once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #827