chore(ci): pin zig-js at #876, the first revision that builds on Zig 1963 - #106
Merged
Conversation
…1963 main has been red on `zig-core` since #104 moved craft to 0.17.0-dev.1963. Every failure was in zig-js at the old pin — that toolchain appends `pointer_stability` to ArrayList, and zig-js had 27 struct literals and one JIT layout assertion that named the old shape. zig-utils/zig-js#876 fixes that upstream, verified there on 1963 (2285 passed, 0 failed) and on the 1818 its own CI pins (53/53 checks). This is the one-line pin to it. Locally, craft's full `zig build` and `zig build test` against this zig-js content on 1963: 153/153 steps, 2519 passed, 0 failed.
✅ Binary load timeWhat this measures
Both binaries are measured interleaved on this runner and compared by |
✅ Binary Size Report
Size limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red onzig-coresince #104 moved craft to0.17.0-dev.1963. Every failure was inside zig-js at the old pin — that toolchain appendspointer_stabilitytoArrayList, and zig-js had 27 struct literals plus one JIT layout assertion that named the old shape.zig-utils/zig-js#876 fixes it upstream — 53/53 checks on the 1818 their CI pins, and 2285 passed / 0 failed on 1963. This is the one-line pin.
Verified locally: craft's full
zig buildandzig build testwith the JS runtime on, against this zig-js content, on 1963 — 153/153 steps, 2519 passed, 0 failed.Unblocks
integration, which has beenskippingbehindzig-core.