Skip to content

chore(ci): pin zig-js at #876, the first revision that builds on Zig 1963 - #106

Merged
glennmichael123 merged 1 commit into
mainfrom
chore/bump-zig-js-1963
Sep 3, 2026
Merged

chore(ci): pin zig-js at #876, the first revision that builds on Zig 1963#106
glennmichael123 merged 1 commit into
mainfrom
chore/bump-zig-js-1963

Conversation

@chrisbbreuer

Copy link
Copy Markdown
Contributor

main has been red on zig-core since #104 moved craft to 0.17.0-dev.1963. Every failure was inside zig-js at the old pin — that toolchain appends pointer_stability to ArrayList, and zig-js had 27 struct literals plus one JIT layout assertion that named the old shape.

zig-utils/zig-js#876 fixes it upstream — 53/53 checks on the 1818 their CI pins, and 2285 passed / 0 failed on 1963. This is the one-line pin.

Verified locally: craft's full zig build and zig build test with the JS runtime on, against this zig-js content, on 1963 — 153/153 steps, 2519 passed, 0 failed.

Unblocks integration, which has been skipping behind zig-core.

…1963

main has been red on `zig-core` since #104 moved craft to
0.17.0-dev.1963. Every failure was in zig-js at the old pin — that
toolchain appends `pointer_stability` to ArrayList, and zig-js had 27 struct
literals and one JIT layout assertion that named the old shape.

zig-utils/zig-js#876 fixes that upstream, verified there on 1963 (2285
passed, 0 failed) and on the 1818 its own CI pins (53/53 checks). This is the
one-line pin to it.

Locally, craft's full `zig build` and `zig build test` against this zig-js
content on 1963: 153/153 steps, 2519 passed, 0 failed.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ Binary load time

rounds:    25 interleaved
base:      p50 19.3ms   p95 20.8ms   (18.7–20.9ms)
head:      p50 19.3ms   p95 20.8ms   (18.7–20.9ms)
delta:     -0.2%  (fails above +20.0%)

No binary load time regression.
What this measures

craft --help: process spawn, dynamic linking and argument parsing.
It never opens a window, so it cannot see a change in window or
webview startup — real startup is benchmarks/startup.bench.ts, which
needs a display.

Both binaries are measured interleaved on this runner and compared by
p50, rather than against a number recorded on another machine. On
byte-identical binaries that method reads within ~3.5%; the old one
swung 45%.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ Binary Size Report

Metric Value
Current Size 14912KB (14.56MB)
Change 0KB (0%) unchanged
Size limits
  • Warning: 14.50MB
  • Maximum: 16.00MB

@glennmichael123
glennmichael123 merged commit b6e3fd4 into main Sep 3, 2026
9 of 10 checks passed
@glennmichael123
glennmichael123 deleted the chore/bump-zig-js-1963 branch September 3, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants