Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current-state opening must preserve the canonical replay order shared by Git visibility and catalog bindings. A ref borrowing an old tip waits until a visible ref supplies it; another eligible producer can change earlier controls’ relative replay order. An immutable per-run rank cannot replace this reconciliation.
Add two metadata regressions sharing one serialized capsule/run fixture:
Validation on committed head
aea42a27837: both storage-only release tests pass, including the original four reconciliation combinations; strict release all-target metadata Clippy, workspace formatting and whitespace checks pass. All 2,637 guarded inputs match their committed Git blobs. The shared fixture replaces duplicated setup; all added code is test-only. No production code, dependencies, formats, configuration or expected-policy records change. The advisor plan and both excluded benchmark reports are absent.Stacked on #594. This guards semantics for the opening optimization; it does not fix the measured 9-to-1,079-operation opening growth across 532 publications. Final combined 10 GiB matrix and representative S3 latency gates remain open.
Evidence map: current file-index opening calls
catalog_capture::capture, thenref_view::order_ref_controlsandVisibilityReconciliation::{ready,apply}. Git control views share that owner; full and paged catalog readers share the same capture. The tests use real metadata codecs, typed root CAS, ref heads and checkpoint/history records. Their pack bodies are metadata fixtures, not native Git or reconstruction proof. Current main lacks the complete capsule stack.Is this the best fix? The production optimization remains pending. These focused tests preserve the observed ordering and checkpoint authority boundaries without another policy, API or fallback. Concurrent writer admission must be audited separately before drawing a publication-race conclusion.