Skip to content

Retain captured browse indexes and original sources across GC #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forhappy wants to merge 5 commits into from
Closed

Retain captured browse indexes and original sources across GC #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c85dc92
fix(gc): retain published browse-index pages
forhappy Oct 15, 2026
2f686bc
fix(gc): retain replaced browse captures
forhappy Oct 15, 2026
1b48997
fix(gc): retain ref-only capture dependencies
forhappy Oct 15, 2026
703f02a
refactor(gc): enumerate index metadata once
forhappy Oct 15, 2026
1fd3251
test(gc): keep captured index pages cold
forhappy Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crab/src/cmd/gc/capsule_cleanup_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ async fn capsule_gc_does_not_report_revalidated_retained_objects_as_deleted() {
.unwrap();
let mut manifest = crab_metadata::manifests::Manifest::default_for_repo("refs/heads/main");
manifest.seal_git_validation();
let state_digest = "a".repeat(64);
let outcome = sweep_capsule_objects(
&GcArgs {
force,
Expand All @@ -236,7 +235,6 @@ async fn capsule_gc_does_not_report_revalidated_retained_objects_as_deleted() {
&layout,
&root,
&[],
&state_digest,
&manifest,
&HashSet::new(),
&CancellationToken::new(),
Expand Down
Loading
Loading