Repository navigation
fix(compile): canonicalize KAK Weyl boundary representatives - #69
Merged
Merged
Conversation
Separate roundoff-scale boundary normalization from unitarity tolerance. Preserve local SU(2) factors and global phase when selecting the positive-c boundary representative, and accept signed c for valid interior coordinates. Add regressions across synthesis backends, caches, device-aware compilation, control flow, and Python/C interfaces. Bump the synthesis algorithm revision.
CXMghost
approved these changes
Oct 19, 2026
CXMghost
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
Valid two-qubit unitaries could fail KAK decomposition because boundary representatives were not normalized to the documented Weyl convention. The validator also used the unitarity tolerance to identify the boundary, incorrectly rejecting nearby interior coordinates with negative c.
Normalize roundoff-scale boundary coordinates and select the positive-c representative while preserving local SU(2) factors and global phase. Keep signed c valid in the chamber interior and retain reconstruction and device-feasibility checks.
Add regressions for the reported matrix, global phases, qubit ordering, all five synthesis backends, caches, resynthesis, device-aware compilation, control flow, and Python/C interfaces. Bump the synthesis algorithm revision.