Repository navigation
fix: preserve certificate outputs and cancel SOCKS auth on shutdown - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independently reproduced correctness fixes:
Regression evidence
make checkpassed, including all Go packages and 51 release-tool tests.make racepassed when run alone. Its first run overlapped the other full suite and failed in an existing fallback fixture before execution with UDPEADDRINUSEon its TCP-selected port. The serial rerun changed no code or assertions; that first setup failure is retained here rather than counted as a pass.No Docker deployment, remote-machine changes, release publication, or comparative traffic experiment is included.