Skip to content

Conversation

@HOMODELUNA
Copy link

@vercel
Copy link

vercel bot commented Jan 6, 2026

@HOMODELUNA is attempting to deploy a commit to the microcber's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator() page looks good, but the std::hash page needs some major changes, including utility component enhancements.

Comment on lines +16 to +46
Defined in header <CppHeader name="bitset" />.

Defined in header <CppHeader name="coroutine" />.

Defined in header <CppHeader name="chrono" />.

Defined in header <CppHeader name="filesystem" />.

Defined in header <CppHeader name="functional" />.

Defined in header <CppHeader name="memory" />.

Defined in header <CppHeader name="optional" />.

Defined in header <CppHeader name="stacktrace" />.

Defined in header <CppHeader name="string" />.

Defined in header <CppHeader name="string_view" />.

Defined in header <CppHeader name="system_error" />.

Defined in header <CppHeader name="text_encoding" />.

Defined in header <CppHeader name="thread" />.

Defined in header <CppHeader name="typeindex" />.

Defined in header <CppHeader name="variant" />.

Defined in header <CppHeader name="vector" />.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This series of header files take too much screen space on the page. I think we have to come up with a way to get around this.

- If `std::hash<Key>` is not provided by the program or the user, it is disabled.
- Otherwise, `std::hash<Key>` is enabled if all following conditions are satisfied:
- All following requirements are satisfied:
- [Hash](../named_req/Hash.html "cpp/named req/Hash") (with `Key` as the function call argument type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <DocLink> for all cross links within cppdoc.


Given a type `Key`, each specialization `std::hash<Key>` is either _enabled_ or _disabled_ :

- If `std::hash<Key>` is not provided by the program or the user, it is disabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave only one space between - and If.

Comment on lines +102 to +105
| | |
|---|---|
|(constuctor) | <Desc kind="public member function">constructs a hash function object </Desc>|
|<DocLink dest="/cpp/library/utility/hash/operator-call"> `operator()` </DocLink> | <Desc kind="public member function">calculates the hash of the argument </Desc>|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This is not right. We need to implement a component for such content.


Possible outputs:

```cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block does not contain C++ source code.

| [LWG 2119](https://cplusplus.github.io/LWG/issue2119) | C++11 | specializations for extended integer types were missing | provided |
| [LWG 2148](https://cplusplus.github.io/LWG/issue2148) | C++11 | specializations for enumerations were missing | provided |
| [LWG 2543](https://cplusplus.github.io/LWG/issue2543) | C++11 | `std::hash` might not be SFINAE-friendly | made SFINAE-friendly |
| [LWG 2817](https://cplusplus.github.io/LWG/issue2817) | C++11 | specialization for [std::nullptr\_t](../types/nullptr_t.html "cpp/types/nullptr_t") was missing | provided |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <DRList> for defect reports list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants