Repository navigation
Pass JSON args to the RunRequest and Engine (DO NOT MERGE - this is just exploring an option) - #181
Draft
drauschenbach wants to merge 4 commits into
Draft
drauschenbach wants to merge 4 commits into
drauschenbach wants to merge 4 commits into
Conversation
drauschenbach
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents callers from having to stringify their args, which may or may not be a JSON object or a plain String.
serde_json::Valuecan convey both, and using what the host provides avoids downstream conversions.If passing args as a JSON Value, it also becomes possible to pass empty args as
serde_json::Value::Null, in case that reads better.