Skip to content

Since the research-person prompt requires every tool in the web pack, require the pack #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drauschenbach wants to merge 1 commit into from
Closed

Since the research-person prompt requires every tool in the web pack, require the pack #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/runvil/tests/suite/shipped.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fn research_ada_lovelace() -> TestResult<Trace> {
}

#[test]
fn the_shipped_research_prompt_offers_its_web_tools_by_id_and_runs_end_to_end() -> TestResult {
fn the_shipped_research_prompt_offers_the_web_pack_and_runs_end_to_end() -> TestResult {
let trace = research_ada_lovelace()?;
assert_eq!(trace.text()?, "a factual summary");

Expand All @@ -48,11 +48,11 @@ fn the_shipped_research_prompt_offers_its_web_tools_by_id_and_runs_end_to_end()
_ => {}
}
}
let wire_names = vec!["web_search".to_owned(), "web_fetch".to_owned()];
let wire_names = vec!["web_fetch".to_owned(), "web_search".to_owned()];
assert_eq!(
advertised,
[wire_names.clone(), wire_names],
"both rounds advertise the offered tools under their wire names, in offer order"
"both rounds advertise the web Pack's tools under their wire names, in id order"
);
assert_eq!(
tool_calls,
Expand Down
2 changes: 1 addition & 1 deletion prompts/research-person.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ models.default("researcher")
## Research

```lua
tools.offer({"web/search", "web/fetch"})
tools.offer("web")
```

You research people using live web tools and return a compact, factual summary.
Expand Down
Loading