Repository navigation
feat: request the maintainer's review on Renovate pull requests - #268
Merged
Merged
Conversation
The preset sets reviewers to cplieger. Renovate now runs as a GitHub App, so the request reaches the maintainer instead of being refused as a request to the pull request's own author. The README says when a review is requested and how another account replaces the reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
"reviewers": ["cplieger"]todefault.json, and documents it in the README: the review-request bullet, and the sentence telling an account that extends the preset to set its ownreviewers. Renovate now runs as a GitHub App, so a review request reaches the maintainer. While it ran ascplieger, GitHub refused a review request to the pull request's own author.Release note
Renovate pull requests that wait for manual approval, or whose automatic merge fails its checks, now request a review from
cplieger. An account that extends this preset sets its ownreviewersto replace that account.Testing
renovate-config-validator --strict(Renovate 44.145.1) passesdefault.jsonas global and as repo config.ci-local.sh: PASS, 2 checks not validated locally (comment ratio and NOTICE audit, run by CI).