Skip to content

rd create and rg create/modify store the layer stack in the caller's case #204

Description

@kvaps

rd create and rg create / rg modify validate a layer stack case-insensitively but store it exactly as the caller spelled it. Some readers compare exactly: the satellite controller's rdNeedsDRBD checks slices.Contains(stack, "DRBD"), and pkg/store/k8s/resources.go has another exact comparison. A definition created with --layer-list drbd,storage is then treated as one without DRBD for allocation, waits and requeues, while the satellite apply path still brings DRBD up.

#190 normalizes layer_list to canonical case on the clone door. The same validate.NormalizeLayerStack call is needed on rd create and on rg create / rg modify, or the exact readers have to fold case.

Found by Codex while reviewing #190; present on main.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions