Conversation
wrapped native token is set from a dummy token and the cowi mport to ensure that the contract can be deployed on local test network
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
saving the native token verification for later PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contract is particularly challenging because it has . I wanted to replicate the checks that we do in the script (ex. checking that
wrappedNativeTokenis actually a WETH contract or something that could concievably be one), but this has turned out to be challenging with the current limitations.Out of Scope
The CI will come later.
Native Token verification in the Cannonfile turned out to be quite challenging as things are, so saving this for a future PR as we approach more networks.
How to Test
To build the cannon package, it currently cowprotocol/contracts#257, so go over there and follow the build instructions for the cannon package there first. (once the package is published there, it will no longer be necessary to build separately)
Then build:
You may need to create the
cannon/directory for the last command to succeed.Also check the docs, see if they are reasonable 👍