Conversation
640e689 to
d9167c2
Compare
aa5a182 to
11fd52a
Compare
|
|
||
| Energy = Fit->Eval(SH->GetADCUnits()); | ||
|
|
||
| if (Energy < 0) { |
There was a problem hiding this comment.
Is there anything left to protect against negative values if we neither do slow nor next neighbor cuts?
There was a problem hiding this comment.
No there is nothing left to protect against negative energy. I just didn't think we wanted to automatically remove negative energy values, especially for the nearest neighbors. But if negative energy breaks other modules then I will add the "if Energy < 0, Energy gets set to 0" safeguard back in.
| if (SH->IsNearestNeighbor() == true) { | ||
| // Get the value user typed in the box (for example 6.0 keV) | ||
| // TODO(@RobinAnthonyPetersen): Nearest Neighbor threhsold cut subject to change pending more analysis | ||
| if (m_NearestNeighborCutMode == MNearestNeighborCutModes::e_Fixed) { |
There was a problem hiding this comment.
What happens if we have Ignore?
There was a problem hiding this comment.
My answer to this changes based on if we can or can't have negative nearest neighbor values
|
Does is compile for you? I get: |
|
I can compile and run nuclearizer from this commit without issues. Gemini says that the issue is that m_BatchSize in src/MModuleLoaderMeasurementsFITS.cxx doesn't have memory allocated for it? It says to add: But I didn't change this file at all so not really sure...? |
|
That should not be a static variable... |
|
Fixed it in the develop/em branch |
|
Let me know when I can merge it. |
|
Hi Andreas, I think this is ready to merge? Or, let me know if there are any other issues to fix. |
|
Can you fix the above mentioned conflicts? Or below... |
Add Nearest Neighbor handling to Energy Calibration and TAC
Remove MModuleNearestNeighbor from GUI and execution flow
associated actions. Nearest Neighbors will now be processed through the
standard strip dataflow with module-specific handling, rather than
relying on this standalone module.
Add option to include/exclude Nearest Neighbors in HDF Loader
Neighbor hits.
Implement configurable energy thresholds for Nearest Neighbors
Updates MModuleEnergyCalibrationUniversal to allow specific cuts on
Nearest Neighbor hits. Users can now select between:
Add Nearest Neighbor timing cuts to MModuleTACcut
Extends TAC module to process Nearest Neighbor hits.