fix(mergify): use status-success for ecp/cross-pr-conflict#398
Merged
Conversation
PRs #386 #387 #388 reached every required-check green, mergeStateStatus=CLEAN, correct ecp:area-* + merge-queue labels — but Mergify check stayed at 'completed/neutral · Merge queue is ready' with payload queue_rule_name=null. None of our queue_conditions matched. Diagnosis: ecp/cross-pr-conflict is a *commit status* set via `gh api -X POST repos/.../statuses/$HEAD_SHA` in ecp-pr-analyze.yml (line 1300 area). Mergify's `check-success=` condition queries the GitHub Checks API, not the Statuses API. The two are separate stores in GitHub. So our `check-success=ecp/cross-pr-conflict` could never match no matter how green the status was. Mergify's documented keyword for matching commit statuses is `status-success=` (parallel keyword to check-success, same syntax, queries the Statuses API instead). Switch all 5 queue_rules. After this lands, the 3 test PRs should auto-embark on next sync.
Contributor
|
[] |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
PRs #386 #387 #388 reached every required-check green, mergeStateStatus=CLEAN, with correct
ecp:area-*+merge-queuelabels — but Mergify check stayed atcompleted/neutral · Merge queue is readywith payloadqueue_rule_name: null. None of our queue_conditions matched.Root cause
ecp/cross-pr-conflictis a commit status (set viagh api -X POST repos/.../statuses/$HEAD_SHAin ecp-pr-analyze.yml). GitHub's Checks API and Statuses API are two different stores in their schema. Mergify'scheck-success=queries Checks API only — socheck-success=ecp/cross-pr-conflictcould never match no matter how green the status was.Mergify's parallel keyword
status-success=queries the Statuses API. Same syntax, just routes the query to the right store.Fix
sed -i 's|check-success=ecp/cross-pr-conflict|status-success=ecp/cross-pr-conflict|g' .mergify.ymlacross all 5 queue_rules.Test plan
neutral / Merge queue is ready→in_progress / In merge queuewith payloadqueue_rule_name: main-docs-only(or matching queue)