Skip to content

Fix coverage double-counting (src/ vs installed package) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lasse Borgholt (borgholt) merged 5 commits into from
Jun 23, 2026
Merged

Fix coverage double-counting (src/ vs installed package) #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06972e2
Fix coverage double-counting between src/ and installed package
borgholt Jun 23, 2026
0e56ca1
Omit research baselines from coverage measurement
borgholt Jun 23, 2026
78075c9
Consolidate coverage config in .coveragerc (address Copilot review)
borgholt Jun 23, 2026
e5a2bb4
Update citation to ICASSP 2026 publication
borgholt Jun 23, 2026
59d5334
Restore title casing in citation title
borgholt Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@ branch = True
source = error_align

[report]
omit = src/error_align/baselines/*
# Match both the editable (src/error_align/...) and installed
# (.../site-packages/error_align/...) layouts so baselines are omitted in
# both local and CI runs.
omit = */baselines/*
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ Alignment(INSERT: "period")
## Citation and Research

```
@article{borgholt2025text,
@inproceedings{borgholt2026text,
title={A Text-To-Text Alignment Algorithm for Better Evaluation of Modern Speech Recognition Systems},
author={Borgholt, Lasse and Havtorn, Jakob and Igel, Christian and Maal{\o}e, Lars and Tan, Zheng-Hua},
journal={arXiv preprint arXiv:2509.24478},
year={2025}
booktitle={ICASSP 2026-2026 IEEE International Conference on Acoustics, Speech and Signal Processing (ICASSP)},
pages={3476--3480},
year={2026},
organization={IEEE}
}
```

Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ignore:
- "src/error_align/baselines/*"
- "**/baselines/**"

coverage:
status:
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,7 @@ build-dir = "build/{wheel_tag}"

[tool.scikit-build.sdist]
include = ["cpp/*", "CMakeLists.txt", "error_align/*", "README.md", "pyproject.toml"]

# NOTE: Coverage.py configuration lives in .coveragerc (which takes precedence
# over pyproject.toml). Keep it there as the single source of truth rather than
# splitting/duplicating coverage settings across two files.
2 changes: 1 addition & 1 deletion pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[pytest]
addopts = --cov=src --cov-report=term --cov-report=xml --typeguard-packages error_align
addopts = --cov=error_align --cov-report=term --cov-report=xml --typeguard-packages error_align
Loading