test: validate embedded component communication - #32
Merged
Morten Barklund (barklund) merged 5 commits intoJul 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds browser-based integration test coverage for the corti-embedded postMessage contract by running the component against a Playwright-routed iframe, plus documentation and CI coverage (including Edge on Windows) ahead of the 1.0 release.
Changes:
- Extend
web-test-runnerPlaywright setup to support multi-browser runs and to intercept/embeddedwith an integration test iframe. - Add a new browser integration test validating request/response round-trips and embedded event surfacing through the public component API.
- Document integration test commands and add a Windows GitHub Actions job to run the integration test in the Microsoft Edge channel.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web-test-runner.config.js | Adds multi-browser Playwright configuration and routes the embedded iframe URL to a local integration frame HTML. |
| test/corti-embedded.integration.test.ts | Introduces browser integration tests for iframe postMessage request/response and embedded event forwarding. |
| README.md | Documents how to run the full suite and the new focused/cross-browser integration test commands. |
| .github/workflows/release.yml | Adds a Windows Edge-channel integration test job and wires it into publish prerequisites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Morten Barklund (barklund)
requested review from
Hammad Saeed (hammadsaeee) and
Zoltan Hricz (hriczzoli)
July 9, 2026 11:24
Zoltan Hricz (hriczzoli)
approved these changes
Jul 10, 2026
Zoltan Hricz (hriczzoli)
left a comment
Zoltan Hricz (hriczzoli)
left a comment
Contributor
There was a problem hiding this comment.
This is great!
Hammad Saeed (hammadsaeee)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds browser-based integration coverage for the embedded web component communication contract ahead of the 1.0 release.
This validates that host application API calls are sent through the real iframe
postMessageboundary, and that embedded responses and events are surfaced back through the public component API and event stream.Changes