refactor: Always return ModelInfo instance#1
Merged
tymondesigns merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
Cortex\ModelInfolibrary, focusing on improving type safety, adding metadata support, and enhancing provider implementations. Key changes include replacing string-based model representations with aModelInfoclass, introducing metadata for models, and updating multiple providers to use the new structure.Enhancements to Model Representation:
ModelInfoclass to include an optionalmetadatafield and correspondinggetMetadatamethod for retrieving metadata by key. Adjusted constructor to allow nullable cost fields (inputCostPerTokenandoutputCostPerToken). [1] [2]ModelInfoProviderinterface and related implementations (LiteLLMModelInfoProvider,LMStudioModelInfoProvider,OllamaModelInfoProvider) to returnModelInfoobjects instead of strings, ensuring type safety. [1] [2] [3] [4]Provider-Specific Improvements:
LMStudioModelInfoProviderto the default providers inModelInfoFactory.OllamaModelInfoProviderandLiteLLMModelInfoProviderto map responses intoModelInfoobjects, improving consistency and extensibility. [1] [2]LMStudioModelInfoProviderandOllamaModelInfoProviderto handle new metadata and improve response handling. [1] [2]Enum and Type Updates:
ModelType::Otherenum case toModelType::Unknownfor clarity.ModelProvidermethods to returnModelInfoobjects instead of strings, aligning with the updated interface. [1] [2]Documentation and Tests:
ModelInfostructure and metadata support. [1] [2]ModelInfoFactoryTest.These changes collectively improve the library's type safety, extensibility, and ability to handle richer model metadata.