-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Update to use newer cs3d #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wayfarer3130
wants to merge
2
commits into
main
Choose a base branch
from
fix/update-latest-cs3d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| /// <reference types="vite/client" /> | ||
|
|
||
| declare module 'virtual:cornerstone-wasm-config' { | ||
| export function getWasmBasePath(): string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import type { Plugin } from 'vite'; | ||
|
|
||
| const VIRTUAL_MODULE_ID = 'virtual:cornerstone-wasm-config'; | ||
| const RESOLVED_VIRTUAL_MODULE_ID = '\0' + VIRTUAL_MODULE_ID; | ||
|
|
||
| export interface VitePluginCornerstoneWasmOptions { | ||
| /** | ||
| * Base path (or URL prefix) for loading WASM binaries. | ||
| * When set, this is passed to Cornerstone's config so WASM URLs are resolved | ||
| * correctly when the app is served under a subpath (e.g. base '/subpath/'). | ||
| * If not set, the plugin does not inject a base path (app can use setConfiguration({ wasmBasePath: import.meta.env.BASE_URL }) instead). | ||
| */ | ||
| wasmBasePath?: string; | ||
| } | ||
|
|
||
| /** | ||
| * Vite plugin that allows replacing the WASM loading path used by Cornerstone | ||
| * (e.g. @cornerstonejs/dicom-image-loader codecs). Use when the app is served | ||
| * under a subpath or you need to point WASM to a custom URL. | ||
| * | ||
| * Usage: | ||
| * 1. Add the plugin with optional wasmBasePath: | ||
| * cornerstoneWasm({ wasmBasePath: '/subpath/' }) | ||
| * 2. In your app entry (e.g. main.tsx), before loading any images: | ||
| * import { getWasmBasePath } from 'virtual:cornerstone-wasm-config'; | ||
| * import { setConfiguration } from '@cornerstonejs/core'; | ||
| * const base = getWasmBasePath(); | ||
| * if (base) setConfiguration({ wasmBasePath: base }); | ||
| * | ||
| * If you don't use the virtual module, you can instead call | ||
| * setConfiguration({ wasmBasePath: import.meta.env.BASE_URL }) for subpath support. | ||
| */ | ||
| export function vitePluginCornerstoneWasm( | ||
| options: VitePluginCornerstoneWasmOptions = {} | ||
| ): Plugin { | ||
| const { wasmBasePath = '' } = options; | ||
|
|
||
| return { | ||
| name: 'vite-plugin-cornerstone-wasm', | ||
| resolveId(id: string) { | ||
| if (id === VIRTUAL_MODULE_ID) return RESOLVED_VIRTUAL_MODULE_ID; | ||
| return null; | ||
| }, | ||
| load(id: string) { | ||
| if (id !== RESOLVED_VIRTUAL_MODULE_ID) return null; | ||
| return ` | ||
| export function getWasmBasePath() { | ||
| return ${JSON.stringify(wasmBasePath)}; | ||
| } | ||
| `; | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| export default vitePluginCornerstoneWasm; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally have our scripts "higher" in the package.json file. Consider moving them.