Skip to content

UntilTag should stop on the first tag greater than the requested tag #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpambrun wants to merge 2 commits into
base: master
Choose a base branch
from
Open

UntilTag should stop on the first tag greater than the requested tag #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff5ea0
use greater than or equal to comparison for options.untilTag
jpambrun Apr 28, 2024
5692b3c
Update webpack so it build on modern node
jpambrun Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 99 additions & 121 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Copy link
Copy Markdown

@Ragnar-Oock Ragnar-Oock Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to make this PR work without updating tooling? It might impact unexpected parts of the code.

Copy link
Copy Markdown
Collaborator Author

@jpambrun jpambrun Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while, but, if I remember correctly, the build was just not working for me.
Otherwise, the tooling changes should not be needed.

Copy link
Copy Markdown
Collaborator Author

@jpambrun jpambrun Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message "Update webpack so it build on modern node" support my memory.

Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
"rusha": "^0.8.14",
"shx": "^0.3.3",
"uglifyjs-webpack-plugin": "^2.2.0",
"webpack": "^4.4.1",
"webpack-cli": "^4.8.0",
"webpack": "^4.47.0",
"webpack-cli": "^4.10.0",
"webpack-dev-server": "^4.2.1"
}
}
4 changes: 2 additions & 2 deletions src/parseDicomDataSet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function parseDicomDataSetExplicit (dataSet, byteStream, maxPosition, opt
const element = readDicomElementExplicit(byteStream, dataSet.warnings, options.untilTag);

elements[element.tag] = element;
if (element.tag === options.untilTag) {
if (element.tag >= options.untilTag) {
return;
}
}
Expand Down Expand Up @@ -59,7 +59,7 @@ export function parseDicomDataSetImplicit (dataSet, byteStream, maxPosition, opt
const element = readDicomElementImplicit(byteStream, options.untilTag, options.vrCallback);

elements[element.tag] = element;
if (element.tag === options.untilTag) {
if (element.tag >= options.untilTag) {
return;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/readDicomElementExplicit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default function readDicomElementExplicit (byteStream, warnings, untilTag
element.hadUndefinedLength = true;
}

if (element.tag === untilTag) {
if (element.tag >= untilTag) {
return element;
}

Expand Down
Loading