Repository navigation
fix(LAN-0): open the move form when jira refuses a move - #21
Merged
Merged
Conversation
A workflow validator that wants a comment (not a FieldRequiredValidator) went unnoticed, so the board posted the bare move and only toasted Jira's 400. The transition endpoint now answers 422 with Jira's reason, and the board opens the move's form with that reason on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving an issue to a status whose workflow validator wants a comment ("Add a comment, or comment first and then move the work item") failed on the web board with only a toast: the validator isn't a FieldRequiredValidator, so
NeedsInputstayed false and the board posted the bare move.jira.Refusalgives Jira's own reason for a 400.POST /issues/{key}/transitionanswers 422 with that reason instead of 502, so the browser can tell a refusal from an outage.board.jsmoveColopens the move form (screen fields plus Comment) with Jira's reason as its intro on a 422; other errors still toast.Test:
TestTransitionRefusedfails on main (502) and passes here. Tested by hand on a real Jira: the Waiting for move now opens the form.The terminal board has the same gap (
prepareJiraMove); not changed here.