Sidecars record delivered audio facts (media block) - #8
Merged
Conversation
Ports xtx.api's delivered-facts sidecar (PR #14) to the TTS wrapper: the record now carries a media block probed from the produced file -- for audio, the delivered duration, sample rate, and channels. The request is intent; the media block is what landed. Probe failure or a missing ffprobe drops the block and never breaks a write. Also guards fn against do.call() callers that spliced the closure source into the record. The engine (chatterbox) stays untouched; provenance lives in the wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports xtx.api#14's delivered-facts sidecar to the TTS wrapper: audio duration, sample rate, channels. Never breaks a write; fixes the fn do.call() splicing. stt.api needs none (record rides on the transcript object). 64 tests.