Strip quotes out from column and table names#94
Merged
Conversation
rathboma
approved these changes
May 21, 2026
Contributor
rathboma
left a comment
rathboma
left a comment
There was a problem hiding this comment.
I think there's a test case that will break it, but otherwise looks good. Going to approve, but please validate the test
|
|
||
| const inner = value.slice(1, -1); | ||
|
|
||
| if (dialect === 'bigquery' && start === '`') { |
Contributor
There was a problem hiding this comment.
Can the dialect -> quote character mapping code be centralized somehow, it seems a bit scattered
| if (dialect === 'mssql') { | ||
| return ['"', '[']; | ||
| } else { | ||
| return ['"', '`']; |
Contributor
There was a problem hiding this comment.
not sure backticks are supported by everything? Are " characters supported by everything?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip out the identifier quoting from identifier tokens for tables and columns. Also unescape anything that was escaped within that token (so
"a""b"will be returned asa"b)