feat(rust): add send_typing_with_status - #101
Draft
KyleYe wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WeChatBot::send_typing_with_status(user_id, status)to the Rust SDK.send_typing(user_id)behavior by delegating to status1.1as start and status2as stop.Motivation
The iLink
/sendtypingendpoint supports status1and2, and the low-level RustILinkClient::send_typingmethod already accepts a status parameter. However, the high-levelWeChatBot::send_typingmethod hardcodes status1, so Rust callers cannot explicitly stop the typing indicator through the high-level API.Developer impact
Existing calls remain unchanged:
Callers can now explicitly stop the indicator:
Backward compatibility
No existing public method signatures are changed. Existing calls to
send_typing(user_id)retain their current status-1behavior.Test plan
cargo fmt --all -- --checkcargo buildcargo test(49 unit tests, 1 public API integration test, and 2 doc tests)git diff --check upstream/main...HEADSupersedes #100, which was closed to resubmit this change from a fresh branch.