chore: remove stubbed tests/ scaffold, keep real coverage#1
Merged
Conversation
The top-level tests/ tree was abandoned scaffolding (unit/integration/e2e/ fixtures stubs); real tests live alongside each module and example. - Relocate the only live test in the tree (shared config/sensor) to modules/_shared/config/sensor/tests/module.tftest.hcl so just test-unit actually discovers and runs it; fix its module source to ./. - Delete the remaining stub READMEs and the duplicate aws/sensor test (already covered by modules/aws/sensor/tests/). - Drop the dead CI step that zipped a dummy lambda_payload into the old tests/unit path; data.archive_file builds the real zip at test time. - Point CONTRIBUTING.md at just test / just test-unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The top-level
tests/directory was abandoned scaffolding — aunit/integration/e2e/fixturesstructure we never adopted. Real tests live alongside each module and example (modules/*/tests/,examples/*/tests/), which is whatjust test-unitactually discovers.Changes
tests/unit/modules/_shared/config/sensor/config.tftest.hcl→modules/_shared/config/sensor/tests/module.tftest.hcl, and fix itsmodule.sourceto./.to match the canonical convention. This was the only coverage for the shared config/sensor module and was silently not running (wrong location). It now runs injust test-unit.tests/— 13 placeholder READMEs plus a duplicateaws/sensortest already covered bymodules/aws/sensor/tests/.lambda_payload.zipinto the oldtests/unit/...path.data.archive_fileinmodules/aws/sensor/lambda.tfbuilds the real zip at test time, so nothing consumed the dummy.CONTRIBUTING.md— pointed at the deletedtests/unit+go test; now points atjust test/just test-unit.Verification
just test-unitrun locally with no pre-staged payload (simulating clean CI): all 14 suites green, 0 failures, including the relocatedmodules/_shared/config/sensor(4 passed).No remaining references to the old
tests/unit|integration|e2e|fixturespaths anywhere in the repo.