Enable https by default#134
Open
davireis wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @coop182 ,
Thanks a lot for this library. Great work.
In my deploy scenario I run your code inside a
<iframe></iframe>, and I hit https://bugs.webkit.org/show_bug.cgi?id=145692, which means that jquery.dfp tries to accessabout://partner.googleadservices.com/gpt/pubads_impl_94.js.The solution that preserves the current behavior involves looping over
parent.location.protocoluntilaboutis gone, or simply doingtop.location.protocol. However, I considered the option of doing simply using https, and that is what is in the current code. This will be a problem for 3rd party creatives that serve over plain http, but I don't really know if this matters nowadays.If you would prefer a different solution, by either looping over
parent.location.protocol, or exposing this is a library flag, I will be happy to update the pull request.I have opportunistically upgraded grunt-contrib-jasmine so tests stop hanging due to gruntjs/grunt-contrib-jasmine#193.