Repository navigation
agents: the flow names each role's profile; spawn refuses others (#758) - #762
Closed
contursofran wants to merge 2 commits into
Closed
contursofran wants to merge 2 commits into
contursofran wants to merge 2 commits into
Conversation
Owner
Author
|
Closed without a merge: the orchestration tool moves to the herdr-contr repository as a Rust port, and the profile guard of this branch is already in its first slice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #758
Steps
agents.Flowgetsprofiles(RoleProfiles: builder, planner, reviewer, debugger, explorer). An empty key is the role's own name;omitzerokeeps old files as they were.Profiles: builder: …, planner: …. Spawn each role with its profile only.(shows incontr agents flow, the compaction hook and the D293 change note).Config.CheckProfile:contr agents spawnand the MCPspawntool refuse a profile the flow names for no role; the error lists the allowed profiles. Override:--any-profile/any_profile: true. An unknown profile still gets the "no profile" error.flow.profiles.The app's orchestrator spawn (
neworch) is not checked: it starts an orchestrator, not a worker role.Pre-check
--any-profilepasses), TestMCPSpawnReadsProfilesEachTime (refused,any_profile, flow edit picked up), TestFlowText. WithCheckProfilemade to return nil, the first three failed.--any-profile,any_profile,flow.profileskeys as in the brief.Checks:
scripts/check.shpasses. Once it hit a flaky test, TestPostToolParallelKeepsAll (pre-existing D293 race, #761); it passed on rerun. No e2e or hccore test covers this code.