Repository navigation
Prompt hook: silent on prompts that are not the owner's (#759) - #760
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #759
Change
promptHookprints the todo line only when the prompt holds the owner's own words.ownerWordsremoves<task-notification>…</task-notification>blocks,<system-reminder>tags and<hc from="…">…</hc>notes; if no text stays, the hook prints nothing (the flow text of a coordinator still goes out as before).session_id,transcript_path,cwd,permission_mode,hook_event_nameandprompt. It has no list of tools, so there is no reliable sign. That part is not changed.Pre-check
TestPromptHookcases for a notification alone, a notification in a system reminder, two hc notes, blank text, and owner words beside a notification or note. With the old check put back, it failed on the notification case.<hc from=prefix check and the blank check are part ofownerWords.