Repository navigation
Hooks: coordinator picks up flow and model edits in agents.json (#753) - #754
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753
What changed
cmd/contr/hookflow.go: hash of the flow text and each profile's--model/--effort; last-seen hash per terminal in<state>/flow-seen/<terminal>.contr hook promptandpost-tool: on a change, a terminal with labelcontr.orchestratingor role orchestrator gets additionalContext "contr: the owner changed the flow and models in agents.json; follow these from now on." + flow + one line per profile. hc is dialed only after a change. Workers (CONTR_COORDINATORset) are skipped.session-start(startup and compact) records the hash, so the first prompt says nothing. With no saved hash, the hook only saves one.agents.Profile.Model()/Effort(); D293 in docs/DECISIONS.md.Pre-check
hookflow_test.gocovers no change, a flow change, a model change, a non-coordinator terminal and a worker, and a bad file. With the change undone, these failed: ChangeReachesCoordinator and ModelChangeReachesPrompt (no context; startup record removed; label check removed), SkipsOtherTerminals (coordinator check forced true), NoChangeSaysNothing (hash compare broken), BadFileIsLogged (error swallowed).scripts/check.shpasses.