Repository navigation
Sidebar: an empty project can start an orchestrator or a terminal, and can be closed (#746) - #751
Merged
Merged
Conversation
…d Close project replaces Hide project (#746, D291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746
Changes
NewOrchestrator.StartInandNewTerminal.Start.empty-project.Why "New orchestrator in " was missing
The item showed only for a group with
Pathset: a stored folder with no hc terminal at all. A project whose terminals held no agent (plain or ended terminals) had rows and noPath, so its menu had only a disabled "Close all agents" and "Hide project". That is the owner's screenshot.Tests
TestProjectWithTerminalsButNoAgentsHasStartsAndNoCloseAll,TestProjectWithWorkersButNoOrchestratorStartsOneInItsFolder,TestProjectMenuNewTerminalOpensInThatProject,TestProjectMenuStartsAreOffWithNoHandler,TestAClickOnAnEmptyProjectSelectsIt, plus the updated menu tests.TestEmptyTerminalWithAProjectRowSelectedStartsInItandTestEmptyTerminalWithNoProjectRowSelectedKeepsItsTexts.scripts/see.sh empty-project dark "site, nothing open"Pre-check
LabelNewInis removed; its start is now the "New orchestrator" item.