Repository navigation
Setup: Install or Enable the contr plugin after a confirm (#713 S3, D283) - #736
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713
Slice S3 of the Setup checklist: the plugin actions (D283, owner decision D65).
Steps
setup.RunPlugin: runs onlyCopyPluginorCopyEnablewith theclaudethe checks find; the error is the last stderr line.Install/Enableright ofCopy. A click opens aui.AlertDialogconfirm with the exact copy line;Runruns it off the UI thread (Env.Do) with a 2 min limit (PluginTimeout). Spinner while it runs, last stderr line inblockedon failure, recheck on success. Seam:Settings.PluginRun.SettingsSetupPlugin(failed Install + open confirm);SettingsSetupnow showsEnable.docs/spec/SettingsSetup.md.No other row gets an action; meter, gh and hc stay copy only.
Tests
go test ./internal/app/settings -run Plugin,go test ./internal/setup -run RunPlugin. No e2e test covers this tab; none run. Sheets:scripts/sheet.sh SettingsSetup SettingsSetupPlugin(Dark and Light, checked by eye).Pre-check
TestPluginEnableRunsTheLineAndRechecks; no error text →TestPluginInstallShowsTheLastErrorLine,TestPluginTimeout; Cancel/Escape runs →TestPluginCancelAndEscapeRunNothing; no spinner →TestPluginSpinnerWhileRunning. TheIDPluginguard inpluginActionis redundant with the Copy match, so removing it alone fails nothing;TestPluginNoButtonOnReadyAndCopyOnlyRowscovers the rows.setup.CopyPlugin/CopyEnable).tmp/sheet/SettingsSetup*-{dark,light}.png(local).