Repository navigation
Settings: the first launch opens the Setup tab (#713 S2, D280) - #730
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #713 (slice S2): the first launch opens Settings → Setup (D280).
Steps
Settings.FirstSetupruns the setup checks once at start, off the UI thread, and gives the frame the number of required steps left (hc core not counted, it can still be connecting).Settings.OpenSetupopens the modal on the Setup tab without a new pass. No timer.prefs.SetupSeen(setupSeen, missing = false), loaded inStartThemeand written bypersist.Frame.firstSetup: steps > 0 and not seen → open on Setup once, storesetupSeen.Deps.SetupRun/Settings.SetupRun: test seam for the pass; nil runssetup.Run.setupSeen: trueunlessh.firstLaunch, so other e2e tests and see fixtures do not get the Settings modal on top.docs/spec/SettingsSetup.md, D280.Tests
TestSetupSeenSaveThenLoad,TestFirstLaunchOpensSetupOnceAndStoresIt,TestSetupDoesNotOpenWhenSeen,TestSetupDoesNotOpenWhenAllReady,TestFirstSetupCountsStepsWithoutTheCoreAndOpensOnSetup,TestFirstSetupWithoutEnvDoesNothing.go test -tags e2e -run TestSetupFirstLaunch ./cmd/contr: PASS (first launch opens Setup, second launch shows only the dot).Pre-check
FirstSetupcall; noseenguard; nosteps > 0guard) andTestSetupSeenSaveThenLoad(field not stored).setupSeenJSON field, D280.internal/app/attach.go.tmp/e2e/setup-first-launch.png(local).