Skip to content

fix(website): keep Page Up and Page Down working in metadata margins #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bircck wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(website): keep Page Up and Page Down working in metadata margins #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Website/app/metadata/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Data() {
<Suspense>
<DatamodelViewProvider>
<EntityFiltersProvider>
<Layout>
<Layout ignoreMargins>
<DatamodelView />
</Layout>
</EntityFiltersProvider>
Expand Down
147 changes: 78 additions & 69 deletions Website/components/datamodelview/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { updateURL } from "@/lib/url-utils";
import { copyToClipboard, generateGroupLink } from "@/lib/clipboard-utils";
import { useSnackbar } from "@/contexts/SnackbarContext";
import { useEntityFilters } from "@/contexts/EntityFiltersContext";
import { Box, CircularProgress, debounce, Tooltip } from '@mui/material';
import { Box, CircularProgress, Container, debounce, Tooltip } from '@mui/material';

interface IListProps {
setCurrentIndex: (index: number) => void;
Expand Down Expand Up @@ -284,76 +284,85 @@ export const List = ({ setCurrentIndex, entityActiveTabs }: IListProps) => {
<Box className={`absolute w-full h-full flex items-center justify-center z-[100] transition-opacity duration-300 ${loadingSection ? 'opacity-100' : 'opacity-0 pointer-events-none'}`}>
<CircularProgress />
</Box>
<div ref={parentRef} style={{ height: 'calc(100vh - var(--layout-header-desktop-height))', overflow: 'auto' }} className="relative no-scrollbar">

{/* Show no results message when searching but no items found */}
{flatItems.length === 0 && search && search.length >= 3 && (
<div className="flex flex-col items-center justify-center h-64 text-gray-500">
<div className="text-lg font-medium mb-2">No tables found</div>
<div className="text-sm text-center">
No attributes match your search for &quot;{search}&quot;
<div
ref={parentRef}
tabIndex={0}
role="region"
aria-label="Metadata tables"
style={{ height: 'calc(100vh - var(--layout-header-desktop-height))', overflow: 'auto' }}
className="relative no-scrollbar"
>
<Container maxWidth="xl">

{/* Show no results message when searching but no items found */}
{flatItems.length === 0 && search && search.length >= 3 && (
<div className="flex flex-col items-center justify-center h-64 text-gray-500">
<div className="text-lg font-medium mb-2">No tables found</div>
<div className="text-sm text-center">
No attributes match your search for &quot;{search}&quot;
</div>
</div>
)}

{/* Virtualized list */}
<div
className={`mx-6 my-6 transition-opacity duration-300 ${loadingSection ? 'opacity-0 pointer-events-none' : 'opacity-100'}`}
style={{
height: `${rowVirtualizer.getTotalSize()}px`,
width: 'calc(100% - 48px)',
position: 'relative',
visibility: flatItems.length === 0 ? 'hidden' : 'visible'
}}
>
{rowVirtualizer.getVirtualItems().map((virtualItem) => {
const item = flatItems[virtualItem.index];

return (
<div
key={virtualItem.key}
data-index={virtualItem.index}
style={{
position: 'absolute',
top: 0,
left: 0,
width: '100%',
transform: `translateY(${virtualItem.start}px)`,
}}
ref={(el) => {
if (el) {
rowVirtualizer.measureElement(el);
}
}}
>
{item.type === 'group' ? (
<div className="flex items-center py-6 my-4">
<div className="flex-1 h-0.5 bg-gray-200" />
<Tooltip title="Copy link to this group">
<div
className="px-4 text-md font-semibold text-gray-700 uppercase tracking-wide whitespace-nowrap cursor-pointer hover:text-blue-600 transition-colors"
onClick={() => handleCopyGroupLink(item.group.Name)}
>
{item.group.Name}
</div>
</Tooltip>
<div className="flex-1 h-0.5 bg-gray-200" />
</div>
) : (
<div className="text-sm">
<Section
entity={item.entity}
group={item.group}
search={search}
activeTab={entityActiveTabs.get(item.entity.SchemaName)}
highlightSecurityRole={selectedSecurityRoles.length > 0 && hasSecurityRoleAccess(item.entity)}
/>
</div>
)}
</div>
);
})}
</div>
)}

{/* Virtualized list */}
<div
className={`mx-6 my-6 transition-opacity duration-300 ${loadingSection ? 'opacity-0 pointer-events-none' : 'opacity-100'}`}
style={{
height: `${rowVirtualizer.getTotalSize()}px`,
width: 'calc(100% - 48px)',
position: 'relative',
visibility: flatItems.length === 0 ? 'hidden' : 'visible'
}}
>
{rowVirtualizer.getVirtualItems().map((virtualItem) => {
const item = flatItems[virtualItem.index];

return (
<div
key={virtualItem.key}
data-index={virtualItem.index}
style={{
position: 'absolute',
top: 0,
left: 0,
width: '100%',
transform: `translateY(${virtualItem.start}px)`,
}}
ref={(el) => {
if (el) {
rowVirtualizer.measureElement(el);
}
}}
>
{item.type === 'group' ? (
<div className="flex items-center py-6 my-4">
<div className="flex-1 h-0.5 bg-gray-200" />
<Tooltip title="Copy link to this group">
<div
className="px-4 text-md font-semibold text-gray-700 uppercase tracking-wide whitespace-nowrap cursor-pointer hover:text-blue-600 transition-colors"
onClick={() => handleCopyGroupLink(item.group.Name)}
>
{item.group.Name}
</div>
</Tooltip>
<div className="flex-1 h-0.5 bg-gray-200" />
</div>
) : (
<div className="text-sm">
<Section
entity={item.entity}
group={item.group}
search={search}
activeTab={entityActiveTabs.get(item.entity.SchemaName)}
highlightSecurityRole={selectedSecurityRoles.length > 0 && hasSecurityRoleAccess(item.entity)}
/>
</div>
)}
</div>
);
})}
</div>
</Container>
</div>
</>
);
Expand Down
Loading