feat(rich-text-links): improve getRichTextEntityLinks()#738
Open
Marco Gonzalez (marcogrcr) wants to merge 2 commits into
Open
feat(rich-text-links): improve getRichTextEntityLinks()#738Marco Gonzalez (marcogrcr) wants to merge 2 commits into
Marco Gonzalez (marcogrcr) wants to merge 2 commits into
Conversation
WHAT? Improve the implementation of `getRichTextEntityLinks()` so that instead of receiving a `type?: string`, it receives `...type: (BLOCKS | INLINES | string)[]`. WHY? When specifying the `type` parameter. Most often than not, there's a need to filter on more than one `type`. Before this change, users were forced to call `getRichTextEntityLinks()` for each type. By accepting multiple values, a single invocation can get all the desired output more efficiently. As for the `BLOCKS | INLINES` in addition to `string`, it's merely used for documentation reminding library users that they can specify the values in there, rather than explicit string values. HOW? `yarn build && yarn test && yarn lint && yarn prettier:check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT?
Improve the implementation of
getRichTextEntityLinks()so that instead of receiving atype?: string, it receives...type: (BLOCKS | INLINES | string)[].WHY?
When specifying the
typeparameter. Most often than not, there's a need to filter on more than onetype. Before this change, users were forced to callgetRichTextEntityLinks()for each type. By accepting multiple values, a single invocation can get all the desired output more efficiently.As for the
BLOCKS | INLINESin addition tostring, it's merely used for documentation reminding library users that they can specify the values in there, rather than explicit string values.HOW?
yarn build && yarn test && yarn lint && yarn prettier:check