fix: improve error handling and logging for asset downloads and tags [AIS-159]#2339
Open
ethan ozelius (ethan-ozelius-contentful) wants to merge 6 commits into
Open
fix: improve error handling and logging for asset downloads and tags [AIS-159]#2339ethan ozelius (ethan-ozelius-contentful) wants to merge 6 commits into
ethan ozelius (ethan-ozelius-contentful) wants to merge 6 commits into
Conversation
- Fix TypeError crash in downloadAsset when HTTP response is absent
(ECONNRESET, DNS failure, timeout) — now wraps with asset ID, URL,
and original error as { cause }
- Add asset ID and URL to all download error messages for traceability
- Emit download errors via logEmitter so they appear in the error log
file, not just transiently in task output
- Add default asset download timeout to prevent indefinite hangs
- Emit warning log when tags fetch fails instead of silently returning
empty array
- Fix editor interface warning logging [object Object] — now uses
contentType.name || contentType.sys.id
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rapping error message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| @@ -46,7 +47,10 @@ async function downloadAsset ({ url, directory, httpClient }) { | |||
| * @type {import('axios').AxiosError} | |||
| */ | |||
| const axiosError = e | |||
Contributor
Author
There was a problem hiding this comment.
Quick type safety check before logging, otherwise throw an error we know will be safe.
60bd006 to
61f62bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIS-97
Summary
Addresses all five Tier 1 bug fixes from AIS-97 — silent failures and crashes in asset downloads and space data fetching.
Test plan
Generated with Claude Code