linux: do not skip EACCES in do_masked_or_readonly_path#2145
Open
Rajkaran-122 wants to merge 1 commit into
Open
linux: do not skip EACCES in do_masked_or_readonly_path#2145Rajkaran-122 wants to merge 1 commit into
Rajkaran-122 wants to merge 1 commit into
Conversation
Only skip ENOENT when opening masked/readonly path targets, matching runc's fail-closed behavior. Previously EACCES was also silently ignored, which could leave a configured maskedPaths/readonlyPaths entry unprotected. Fixes: containers#2139 Signed-off-by: Rajkaran <rajkaran122@example.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
|
I am not sure yet whether we need this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When attempting to open a masked or read-only path,
crunwas silently ignoring bothENOENTandEACCESerrors.To maintain consistency with
runc's fail-closed behavior, this commit updates the logic so that onlyENOENTis silently ignored. IfEACCESis encountered, the error is now properly propagated, preventing potential protection bypasses if a masked/readonly paths entry cannot be opened due to permissions.Fixes: #2139