Skip to content

docs: fix grammar and formatting issues in crun.1.md#2143

Open
Rajkaran-122 wants to merge 1 commit into
containers:mainfrom
Rajkaran-122:docs-fix-man-page
Open

docs: fix grammar and formatting issues in crun.1.md#2143
Rajkaran-122 wants to merge 1 commit into
containers:mainfrom
Rajkaran-122:docs-fix-man-page

Conversation

@Rajkaran-122

Copy link
Copy Markdown

Description:
This commit fixes a few minor typographical and formatting issues in the crun man page:

  • Fixed a missing markdown bold marker for the -u/--user option.
  • Fixed grammar: "how the context mount flags works" -> "work".
  • Fixed grammar: "each children mount" -> "each child mount".
  • Fixed grammar: "an user namespace" -> "a user namespace".

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@packit-as-a-service

Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

please fix the commit message with your real name/email.

Also commit the crun.1 file

@giuseppe

Copy link
Copy Markdown
Member

do not use a merge commit, do a proper rebase e.g. git rebase -i origin/main

@Rajkaran-122
Rajkaran-122 force-pushed the docs-fix-man-page branch 2 times, most recently from c7cf6da to 2fd2d4d Compare July 27, 2026 07:08
@giuseppe

Copy link
Copy Markdown
Member

the regenerated crun.1 file is still missing

@Rajkaran-122

Copy link
Copy Markdown
Author

Thanks, sir. I really appreciate your guidance. I'll make sure to follow these practices from now on. This is my first contribution to a large open-source repository, so I'm still learning. Thank you for your feedback.

@giuseppe

Copy link
Copy Markdown
Member

again, you need to rebase, not merge

- Fix grammar: 'each children mount' -> 'each child mount'

- Fix grammar: 'an user namespace' -> 'a user namespace'

Signed-off-by: Rajkaran Yadav <yadavrajkaran854@gmail.com>
@Rajkaran-122

Copy link
Copy Markdown
Author

again, you need to rebase, not merge

yes sir i have did it
Please let me know if there's anything else that needs to be updated.

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants