Skip to content

Fix online help search - #2572

Merged
antares1470 merged 1 commit into
masterfrom
bugfix/fix-online-help-search
Sep 21, 2026
Merged

antares1470 merged 1 commit into
masterfrom
bugfix/fix-online-help-search

Conversation

@Delphinus8821

Copy link
Copy Markdown
Collaborator

Prerequisites

  • Reviewed the checklist

  • Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
    for the "CI / Unit Tests") to complete first. Failed Unit tests can be
    debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Since the domain change, the search function in online help hasn't been working.
This is a potential fix for the search but it cannot be tested until it has been merged.

Alternate Designs

Why Should This Be In Core?

Fix for something in Core

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

@sonarqubecloud

Copy link
Copy Markdown

Comment thread search.json
"title": "About Constellation",
"category": "Overview",
"link": "ext\\docs\\CoreFunctionality\\about-constellation.html"
"link": "../ext\\docs\\CoreFunctionality\\about-constellation.html"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this needs to be \\ rather than /

@Delphinus8821 Delphinus8821 Sep 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the \\ is just for when it is run from offline help, and it still functions in that case. All of the links in online help are / so I'm not sure whether it matters

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I've just tested using ..\\ and that does not work in offline help

@antares1470
antares1470 merged commit bc06c48 into master Sep 21, 2026
3 checks passed
@antares1470
antares1470 deleted the bugfix/fix-online-help-search branch September 21, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants