Fix the exception when exporting a map to Shapefile - #2569
Open
Auriga2 wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 2a461cb4d407c4e8222729bdd953029ffed99100)
|
Auriga2
requested review from
Delphinus8821,
Quasar985,
andromeda-224 and
antares1470
September 10, 2026 09:28
antares1470
reviewed
Sep 11, 2026
| writableFeature.setAttribute(compatibleAttributeName, attributeValue); | ||
| writableFeature.setAttribute(compatibleAttributeName.strip(), attributeValue); | ||
| } else if (schemaAttributes.containsKey(compatibleAttributeName) && attributeValue != null) { | ||
| writableFeature.setAttribute(compatibleAttributeName, attributeValue.toString()); |
Collaborator
There was a problem hiding this comment.
should this case also include a .strip()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
The unexpected exception when exporting a map to Shapefile, while containing any custom attribute with a space in the 10th character, is fixed now.
Alternate Designs
Why Should This Be In Core?
Bug Fix
Benefits
Handles unexpected exception
Possible Drawbacks
Verification Process
ExportApplicable Issues
#2568