chore(nft): drop dead Solscan Solana-NFT path - #1454
Merged
Conversation
Solscan backed only the Solana NFT-collection lookup, and its prod token has been absent, so the feature already returned empty in practice. CreateSolanaNFTCollection now short-circuits to a typed ErrSolanaNFTCollectionNotSupported (400) instead of calling Solscan, so the "sol" branch of the shared CreateNFTCollection route stays wired but returns a clean, typed response. With the NFT path gone, svc.Solscan had no remaining callers, so this also retires the whole integration: the service field + registration, pkg/service/solscan/, pkg/response/solscan.go (types were Solscan-only), and the Solscan config field / SOLSCAN_TOKEN env binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidation follow-up (decision: drop, not migrate). Solscan was used ONLY for Solana NFT collection lookups and prod has no
SOLSCAN_TOKEN, so the feature already returned empty.CreateSolanaNFTCollection(nfts.go) now returns a typedErrSolanaNFTCollectionNotSupported(clean 400, never 500). The sharedPOST /nfts/collectionsroute + apt/sui/EVM branches are untouched (not Solana-only).pkg/service/service.go, deletedpkg/service/solscan/+pkg/response/solscan.go(Solscan-only types), removed theSolscan/SOLSCAN_TOKENconfig field. No other live caller (grep-verified).rg Solscan pkg/ cmd/= zero live calls.Note:
SOLSCAN_TOKENwas never actually in prod Vault (absent), so no Vault delete needed. Runbook's stale 'Solscan STAYS' line to be fixed in a follow-up.CI gitleaks/CI-testing baseline-broken (see #1438); 2 reproducible entities baseline fails, unrelated.
🤖 Generated with Claude Code