Add editions support#40
Open
AdrienVannson wants to merge 4 commits into
Open
Conversation
AdrienVannson
force-pushed
the
implement-editions
branch
from
e67512a to
54469e9
Compare
Signed-off-by: Adrien Vannson <avannson@buf.build>
Signed-off-by: Adrien Vannson <avannson@buf.build>
Signed-off-by: Adrien Vannson <avannson@buf.build>
Signed-off-by: Adrien Vannson <avannson@buf.build>
AdrienVannson
force-pushed
the
implement-editions
branch
from
54469e9 to
0d08c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37 (I noticed during triage that this issue seems straightforward to fix so I had a quick look)
This allows generating code for proto files using editions. Editions are a protobuf feature, so I don't expect any impact on this connect lib.
This consists mostly of marking editions as supported in the
CodeGeneratorResponse. I also added a test to compile an edition file and make sure the flags are set correctly, and updated buf.I tested editions locally by running the eliza example after converting the proto file to editions: everything works correctly with the changed proposed by this PR.