Skip to content

Protobuf v6#38

Open
jgasparetti wants to merge 5 commits into
connectrpc:mainfrom
jgasparetti:protobuf-v6
Open

Protobuf v6#38
jgasparetti wants to merge 5 commits into
connectrpc:mainfrom
jgasparetti:protobuf-v6

Conversation

@jgasparetti
Copy link
Copy Markdown

No description provided.

Signed-off-by: Jacopo Gasparetti <jgasparetti@gmail.com>
Signed-off-by: Jacopo Gasparetti <jgasparetti@gmail.com>
… packages; refactor library declarations in conformance package files.

Signed-off-by: Jacopo Gasparetti <jgasparetti@gmail.com>
protobuf to 6.0.01
buf.build/connectrpc/conformance to 1.0.4
buf.build/protocolbuffers/dart to 25.0.0
buf.build/protocolbuffers/wellknowntypes to 34.

Signed-off-by: Jacopo Gasparetti <jgasparetti@gmail.com>
Signed-off-by: Jacopo Gasparetti <jgasparetti@gmail.com>
@jgasparetti
Copy link
Copy Markdown
Author

Summary
In order to enable the use of protobuf v6, I had to update both the related libraries and the buf.build dependencies.

Changes

  • Updated protobuf to version 6
  • Updated dependent libraries accordingly
  • Updated buf.build configurations to ensure compatibility

Notes
It’s important to highlight the strong coupling between connect-dart and protobuf versions.
To avoid compatibility issues, it is recommended to align their versions as follows:

  • connect-dart ~ v4 → uses protobuf v4
  • connect-dart ~ v6 → uses protobuf v6

Keeping these versions aligned should help prevent inconsistencies and runtime issues.

Copy link
Copy Markdown
Member

@srikrsna-buf srikrsna-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. To minimize breaking users, I would like to do this is multiple steps. Can we first update to v5 while supporting the old versions. AFAIK, this shouldn't be a breaking change.

Once that is released, we can cut a new version that supports v6 and above.

@hansbala
Copy link
Copy Markdown

@jgasparetti let me know if you need help. I am also looking to support protobuf v6 in my packages.

@jgasparetti
Copy link
Copy Markdown
Author

Thank you for the PR. To minimize breaking users, I would like to do this is multiple steps. Can we first update to v5 while supporting the old versions. AFAIK, this shouldn't be a breaking change.

Once that is released, we can cut a new version that supports v6 and above.

OK, I am going to work in that direction, from the first runs it seems that BuilderInfo.fromProto3Json and BuilderInfo.toProto3Json are removed and the generated proto are no longer working. I am going to test with an updated version of buf.build/protocolbuffers/dart respect to the v21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants