fix: use package:protobuf imports for wellknown types#36
Open
xander1421 wants to merge 1 commit into
Open
Conversation
Add plugin option to control how wellknown types (google.protobuf.*) are imported. When enabled (default: true), imports from package:protobuf/well_known_types/ instead of relative paths. This matches the default behavior of protocolbuffers/dart plugin and prevents type mismatches when using both plugins together. Options: - wellknown_from_package=true (default): use package:protobuf imports - wellknown_from_package=false: use relative imports (for custom setups) Also updates protobuf constraint to >=4.0.0 <7.0.0 for protobuf 6.x. Fixes connectrpc#33
xander1421
force-pushed
the
fix/wellknown-types-package-imports
branch
from
10b6d16 to
3ec5734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Problem
When using connect-dart with
protocolbuffers/dartplugin, wellknown types (google.protobuf.*) are provided bypackage:protobuf/well_known_types/rather than being generated locally.Previously, connect-dart always generated relative imports for these types, causing type mismatches at runtime.
Solution
Add a new plugin option
wellknown_from_package(default:true) that controls how wellknown types are imported:wellknown_from_package=true(default): imports frompackage:protobuf/well_known_types/wellknown_from_package=false: generates relative imports (for custom setups)Also updates protobuf constraint to
>=4.0.0 <7.0.0for protobuf 6.x support.Usage
Supported wellknown types
Any, Duration, Empty, FieldMask, Struct, Value, ListValue, NullValue, Timestamp, and all wrapper types.