Repository navigation
🚨 Update npm dependencies (main) (major) #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,25 +22,25 @@ | |
| "dependencies": { | ||
| "@emotion/react": "^11.11.1", | ||
| "@emotion/styled": "^11.11.0", | ||
| "@mui/material": "^5.14.16", | ||
| "@mui/material": "^9.0.0", | ||
| "buffer": "^6.0.3", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "react-redux": "^9.0.0", | ||
| "redux": "^5.0.0", | ||
| "web-vitals": "^3.0.0" | ||
| "web-vitals": "^6.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.2.43", | ||
| "@types/react-dom": "^18.2.17", | ||
| "@vitejs/plugin-react-swc": "^3.10.1", | ||
| "eslint": "^8.55.0", | ||
| "@types/react": "^19.0.0", | ||
| "@types/react-dom": "^19.0.0", | ||
| "@vitejs/plugin-react-swc": "^4.0.0", | ||
| "eslint": "^10.0.0", | ||
| "eslint-plugin-react": "^7.33.2", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "eslint-plugin-react-hooks": "^7.0.0", | ||
| "eslint-plugin-react-refresh": "^0.4.5", | ||
| "vite": "^6.3.5" | ||
| "vite": "^8.0.0" | ||
|
Comment on lines
+34
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: ls -a
cat package.json
ls .github/workflows 2>/dev/null && cat .github/workflows/* 2>/dev/null | head -100Repository: conforma/policy-builder Length of output: 4497 🏁 Script executed: printf '%s\n' '--- ESLint configs and lint references ---'
git ls-files | grep -E '(^|/)(\.eslintrc([^.]*|\..*)?|eslint\.config\.[^/]+)$|(^|/)(package\.json|package-lock\.json)$|^\.github/workflows/'
rg -n --hidden --glob '!.git/**' 'eslint|npm run lint' .github package.json .eslintrc.cjs
printf '%s\n' '--- config ---'
cat -n .eslintrc.cjs
printf '%s\n' '--- package and lockfile ESLint declarations ---'
sed -n '28,55p' package.json
rg -n -A8 -B2 '"node_modules/eslint"|"eslint": "\^?10|"version": "10\.' package-lock.json | head -80
printf '%s\n' '--- PR changes for lint config/package ---'
git diff --no-ext-diff --unified=4 0d37a0add3770c6ed94b339055976315911cecda 06f5f4f40f0e6fc3dcf2757cca40e83d07458cd2 -- package.json package-lock.json .eslintrc.cjsRepository: conforma/policy-builder Length of output: 3729 🏁 Script executed: printf '%s\n' '--- ESLint manifest and lock root ---'
cat -n package.json | sed -n '14,43p'
cat -n package-lock.json | sed -n '1,48p'
cat -n package-lock.json | sed -n '2380,2398p'
printf '%s\n' '--- build install command ---'
cat -n .github/workflows/build.yaml | sed -n '20,45p'
printf '%s\n' '--- official ESLint v10 migration guide excerpt ---'
python3 - <<'PY'
import urllib.request
url = "https://eslint.org/docs/v10.x/use/configure/migration-guide"
try:
with urllib.request.urlopen(url, timeout=15) as response:
text = response.read().decode("utf-8", "replace")
for term in ("eslintrc", "flat config", "ESLint v10"):
pos = text.lower().find(term.lower())
print(f"{term}:")
print(text[max(0, pos-350):pos+900] if pos >= 0 else "not found")
except Exception as exc:
print(f"FETCH_FAILED: {type(exc).__name__}: {exc}")
PYRepository: conforma/policy-builder Length of output: 7531 🏁 Script executed: python3 - <<'PY'
from html.parser import HTMLParser
import urllib.request
url = "https://eslint.org/docs/v10.x/use/configure/migration-guide"
with urllib.request.urlopen(url, timeout=15) as response:
body = response.read().decode("utf-8", "replace")
print("final_url:", response.geturl())
class Text(HTMLParser):
def __init__(self):
super().__init__()
self.parts = []
def handle_data(self, value):
value = " ".join(value.split())
if value:
self.parts.append(value)
parser = Text()
parser.feed(body)
text = "\n".join(parser.parts)
for term in ("eslintrc", "removed", "legacy configuration"):
print(f"--- {term} matches ---")
start = 0
count = 0
while True:
pos = text.lower().find(term.lower(), start)
if pos < 0 or count == 8:
break
print(text[max(0, pos-280):pos+700])
start = pos + len(term)
count += 1
if count == 0:
print("not found")
PYRepository: conforma/policy-builder Length of output: 9158 🏁 Script executed: python3 - <<'PY'
import json
import urllib.request
url = "https://api.github.com/repos/eslint/eslint/releases/tags/v10.0.0"
request = urllib.request.Request(url, headers={"Accept": "application/vnd.github+json", "User-Agent": "review-evidence-reader"})
try:
with urllib.request.urlopen(request, timeout=15) as response:
release = json.load(response)
print("release:", release.get("html_url"))
print("name:", release.get("name"))
body = release.get("body", "")
for term in ("eslintrc", "flat config", "flat configuration"):
pos = body.lower().find(term.lower())
print(f"--- {term} ---")
print(body[max(0, pos-500):pos+1200] if pos >= 0 else "not found")
except Exception as exc:
print(f"FETCH_FAILED: {type(exc).__name__}: {exc}")
PYRepository: conforma/policy-builder Length of output: 2020 Convert When ESLint 10 is installed as declared, 🤖 Prompt for AI Agents |
||
| }, | ||
| "engines": { | ||
| "node": "20" | ||
| "node": "24" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Update the lockfile with the dependency changes.
The supplied
package-lock.jsonroot snapshot still requires@mui/material^5.14.16and React^18.2.0. These requirements conflict withpackage.json. A cleannpm ciinstall rejects an out-of-sync lockfile. Regenerate and commitpackage-lock.jsonfor the new dependency and engine requirements. As per path instructions, this comment focuses on a major workflow issue and avoids nitpicks.🤖 Prompt for AI Agents
Source: Path instructions