DGS-23025 Add AssociatedNameStrategy by rayokota · Pull Request #454 · confluentinc/confluent-kafka-javascript

Robert Yokota (rayokota) · 2026-02-23T23:26:30Z

What

Add AssociatedNameStrategy, which is now the default
Also add RecordNameStrategy and TopicRecordNameStrategy
Modified SubjectNameStrategyFunc to support async implementations (returns string | Promise)
Add tests

Checklist

[Y] Contains customer facing changes? Including API/behavior changes
[Y] Did you add sufficient unit test and/or integration test coverage for this PR?
- If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

Copilot

Pull request overview

This pull request adds support for AssociatedNameStrategy in the TypeScript schema registry client, which allows subject names to be determined by querying associations stored in the schema registry. The PR also adds support for RecordNameStrategy and TopicRecordNameStrategy, and makes the SubjectNameStrategyFunc type support both synchronous and asynchronous implementations.

Changes:

Added AssociatedNameStrategy that queries schema registry associations to determine subject names
Added RecordNameStrategy and TopicRecordNameStrategy for schema-based subject naming
Modified SubjectNameStrategyFunc to support async implementations (returns string | Promise<string>)
Added association-related types and API methods to the schema registry client
Added comprehensive test coverage for the new strategies

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
schemaregistry/serde/serde.ts	Core implementation of AssociatedNameStrategy, RecordNameStrategy, TopicRecordNameStrategy, and related helper functions; modified SubjectNameStrategyFunc signature to support async
schemaregistry/serde/avro.ts	Added getRecordName method to AvroSerializer and AvroDeserializer; configured subject name strategy in constructors
schemaregistry/serde/json.ts	Added getRecordName method to JsonSerializer and JsonDeserializer; configured subject name strategy in constructors
schemaregistry/serde/protobuf.ts	Added getRecordName method to ProtobufSerializer and ProtobufDeserializer; configured subject name strategy in constructors
schemaregistry/schemaregistry-client.ts	Added Association-related types, LifecyclePolicy enum, and API methods for managing associations
schemaregistry/mock-schemaregistry-client.ts	Implemented association management in mock client; modified getBySubjectAndId to support empty subject lookups
schemaregistry/test/serde/avro.spec.ts	Added comprehensive tests for RecordNameStrategy, TopicRecordNameStrategy, and AssociatedNameStrategy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

schemaregistry/serde/serde.ts

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

schemaregistry/serde/serde.ts

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

schemaregistry/schemaregistry-client.ts

schemaregistry/mock-schemaregistry-client.ts

schemaregistry/serde/serde.ts

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

schemaregistry/serde/serde.ts

schemaregistry/test/serde/avro.spec.ts

schemaregistry/serde/serde.ts

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

schemaregistry/serde/serde.ts

schemaregistry/schemaregistry-client.ts

sonarqube-confluent · 2026-03-05T00:57:04Z

Quality Gate failed

Failed conditions
58.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Robert Yokota (rayokota) requested a review from a team as a code owner February 23, 2026 23:26

Copilot AI review requested due to automatic review settings February 23, 2026 23:26

Robert Yokota (rayokota) requested a review from a team as a code owner February 23, 2026 23:26

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 23, 2026 23:26 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

schemaregistry/serde/serde.ts Outdated Show resolved Hide resolved

Robert Yokota (rayokota) requested a review from Copilot February 24, 2026 01:05

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 24, 2026 01:06 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Robert Yokota (rayokota) requested a review from Copilot February 24, 2026 01:38

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 24, 2026 01:38 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

schemaregistry/serde/serde.ts Outdated Show resolved Hide resolved

schemaregistry/serde/serde.ts Show resolved Hide resolved

Robert Yokota (rayokota) requested a review from Copilot February 24, 2026 05:09

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 24, 2026 05:10 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Robert Yokota (rayokota) requested a review from Copilot February 25, 2026 05:02

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 25, 2026 05:03 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Robert Yokota (rayokota) requested a review from Copilot February 25, 2026 21:21

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 25, 2026 21:22 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

schemaregistry/serde/serde.ts Outdated Show resolved Hide resolved

schemaregistry/test/serde/avro.spec.ts Show resolved Hide resolved

schemaregistry/serde/serde.ts Outdated Show resolved Hide resolved

schemaregistry/serde/serde.ts Show resolved Hide resolved

Robert Yokota (rayokota) requested a review from Copilot February 27, 2026 02:39

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 27, 2026 02:39 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Robert Yokota (rayokota) requested a review from Copilot February 27, 2026 18:55

Copilot started reviewing on behalf of Robert Yokota (rayokota) February 27, 2026 18:56 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

schemaregistry/serde/serde.ts Show resolved Hide resolved

schemaregistry/schemaregistry-client.ts Show resolved Hide resolved

Robert Yokota (rayokota) added 4 commits March 4, 2026 16:42

First cut at AssociatedNameStrategy refactor

35fdf0a

Implement associated name strategy

4b9fd53

Minor refactor

42fa27f

Minor cleanup

1c95641

Robert Yokota (rayokota) added 16 commits March 4, 2026 16:42

Add more assoc apis

20066c2

handle 404

8060f4d

Minor opt

7664f29

Implement record strategy

ad3e2d2

Incorporate review feedback

1d1e9c3

Incorporate review feedback

42c0c52

Fix record name strategy

5965554

Incorporate review feedback

d12a22f

Fix tests

d6ce9ed

Add tests

c17c6c2

Fix RecordType handling in subject name strategy

db27a8e

minor fixes

a98b0d1

Make Associated the default strategy

d8b0440

remove dead code

275db56

Minor renaming

a3680b0

Minor test cleanup

3db0252

airlock-confluentinc bot force-pushed the assoc-strategy branch from 84beda5 to 3db0252 Compare March 5, 2026 00:43

Conversation

Robert Yokota (rayokota) commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Checklist

References

Test & Review

Open questions / Follow-ups

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sonarqube-confluent bot commented Mar 5, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Robert Yokota (rayokota) commented Feb 23, 2026 •

edited

Loading